[Webkit-unassigned] [Bug 233230] [GStreamer] MediaPlayerPrivateGStreamer mishandles failure to create WebKitTextCombiner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233230

--- Comment #7 from Alberto Garcia <berto at igalia.com> ---
(In reply to Michael Catanzaro from comment #1)
> CC: Berto because it's worth checking the Debian packaging to ensure it has
> a Recommends: to ensure this isn't broken by default. In Fedora I have
> Recommends: on both gst-plugins-good and gst-plugins-bad. I see you have a
> Requires: on gst-plugins-good in Debian (a little aggressive, but OK), and a
> Recommends: ${gst:Recommends}. I wonder what that ${gst:Recommends}
> evaluates to. gst-plugins-good and -bad are both optional in case users want
> to uninstall them, but important to have by default.

In Debian we depend on -base and -good, and recommend -gl, -bad and -libav

I don't remember the exact discussion at the moment, but I think I
depended on -good in order to have an audio sink available, otherwise
we were hitting this assertion:

https://salsa.debian.org/webkit-team/webkit/-/blob/debian/2.32.1-1_deb10u1/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L1322

The recommended packages are necessary in order to play videos
(YouTube etc).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211118/825085f7/attachment-0001.htm>