[Webkit-unassigned] [Bug 233230] [GStreamer] Webkit on ubuntu 21.10 is failing due to a missing gstreamer1.0-plugins-bad package

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233230

Michael Catanzaro <mcatanzaro at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |berto at igalia.com,
                   |                            |mcatanzaro at gnome.org
          Component|WebKitGTK                   |Media
            Summary|Webkit on ubuntu 21.10 is   |[GStreamer] Webkit on
                   |failing due to a missing    |ubuntu 21.10 is failing due
                   |gstreamer1.0-plugins-bad    |to a missing
                   |package                     |gstreamer1.0-plugins-bad
                   |                            |package

--- Comment #1 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to openaudible from comment #0)
> The code that fails is calling webkitTextCombinerNew() and asserting that
> the object returned is not null.
> Error message is: "WebKit wasn't able to find a WebVTT encoder. Not
> continuing without platform support for subtitles"

So far so good from WebKit's perspective. Printing an error message when the optional package is missing is the right thing to do.

CC: Berto because it's worth checking the Debian packaging to ensure it has a Recommends: to ensure this isn't broken by default. In Fedora I have Recommends: on both gst-plugins-good and gst-plugins-bad. I see you have a Requires: on gst-plugins-good in Debian (a little aggressive, but OK), and a Recommends: ${gst:Recommends}. I wonder what that ${gst:Recommends} evaluates to. gst-plugins-good and -bad are both optional in case users want to uninstall them, but important to have by default.

> And library quits on ASSERT failure.

That would be a WebKit bug: it shouldn't crash. But you didn't provide any info that would tell us where the problem is. Please provide a backtrace taken with gdb following the instructions at https://blogs.gnome.org/mcatanzaro/2021/09/18/creating-quality-backtraces-for-crash-reports/. Thanks.

> A bug fix in webkit would be to not fail if the webVTT plugin isn't
> available.. or use a different plugin that is "not bad"? Or improve the
> error message to make it clear a GStreamer plugin that provides WebVTT is
> not installed. 

>From an upstream perspective, we just need to make it not crash. I think the error message is sufficiently detailed that somebody who has intentionally chosen not to install recommended packages should be able to figure out that a GStreamer element is missing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211117/fad04559/attachment.htm>