[Webkit-unassigned] [Bug 185416] Empty <input type=file> is represented incorrectly in FormData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 15:58:19 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=185416

--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 444343
  --> https://bugs.webkit.org/attachment.cgi?id=444343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444343&action=review

> Source/WebCore/html/FileInputType.cpp:182
> +    // application/octet-stream content type. Null would be more logical, but

I don’t think this comment change is an improvement; mentioning exactly what the code does is a non-goal for comments. The comment needs to cover "why", but no reason for it to say exactly "what".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211116/79bb5ef0/attachment.htm>


More information about the webkit-unassigned mailing list