[Webkit-unassigned] [Bug 233143] [JSC] Shadow realms: set correct Function prototype on wrapped functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 16 07:09:56 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=233143

Phillip Mates <pmates at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pmates at igalia.com

--- Comment #3 from Phillip Mates <pmates at igalia.com> ---
Comment on attachment 444299
  --> https://bugs.webkit.org/attachment.cgi?id=444299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444299&action=review

> Source/JavaScriptCore/runtime/ShadowRealmPrototype.cpp:141
> +    wrappedFn->setPrototype(vm, targetGlobalObj, targetGlobalObj->strictFunctionStructure(isBuiltin)->storedPrototype());

Any idea if `setPrototype` plays nice with function inlining optimizations? Might be worth trying to get some coverage for this change in the stress tests (like in JSTests/stress/shadow-realm-evaluate.js where we try to force inlining)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211116/71f443c3/attachment.htm>


More information about the webkit-unassigned mailing list