[Webkit-unassigned] [Bug 229917] Correctly support fragment-only URLs in CSS images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229917

--- Comment #15 from Matt Woodrow <m_woodrow at apple.com> ---
Comment on attachment 444204
  --> https://bugs.webkit.org/attachment.cgi?id=444204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444204&action=review

>> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:3620
>> +            }
> 
> Is this only for image URLs? What about other CSS URLs? I think this logic should probably go in the CSSParserContext::completeURL function.

It looks like we already have two (slightly different) implementations of completeURL, in CSSParserContext and Document.

One option would be to add a new method to wtf::URL (static construction helper) which handles this specific logic, and use that from both completeURL imps, though I'm unsure if WTF is an appropriate place for css-values-specific logic.

Having a separate helper method that we call from both completeURL impls would also work, though I'm not sure where the best spot for that to live is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211116/17cd437d/attachment.htm>