[Webkit-unassigned] [Bug 233011] New: [WebAuthn] Stop serializing BufferSource and Vector<uint8_t> duplicates of identifiers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 11 13:42:10 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=233011

            Bug ID: 233011
           Summary: [WebAuthn] Stop serializing BufferSource and
                    Vector<uint8_t> duplicates of identifiers
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

The original WebAuthn logic converted WebCore::BufferSource objects to Vector<uint8_t> for serialization, which created a weird design where some code dealt with BufferSource objects, and other with Vectors, and lots of converting to and from these types. It also caused WebAuthn data structures to have two places where this information might live, with the UIProcess using one representation, and the WebContent process using another.

This patch revises the code as follows:

1. The identifiers are always stored as BufferSource, and the same member is used in UIProcess and WebContent process when accessing this information.
2. We now serialize BufferSource directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211111/16cf93e3/attachment-0001.htm>


More information about the webkit-unassigned mailing list