[Webkit-unassigned] [Bug 232922] bad_optional_access in RenderGrid::updateAutoMarginsInRowAxisIfNeeded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 11 02:59:41 PST 2021


--- Comment #4 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 443774
  --> https://bugs.webkit.org/attachment.cgi?id=443774

View in context: https://bugs.webkit.org/attachment.cgi?id=443774&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1260
> +    std::optional<LayoutUnit> availableHeight = child.overridingContainingBlockContentLogicalHeight();

Maybe we could just use value_or(LayoutUnit()) as we already do in other functions of this class to handle the available space. In case of nullopt, we will use the early return already defined for non-positive values.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211111/99cd53b3/attachment.htm>

More information about the webkit-unassigned mailing list