[Webkit-unassigned] [Bug 232975] New: Move m_doesGC from Heap to VM.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 10 17:18:06 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=232975

            Bug ID: 232975
           Summary: Move m_doesGC from Heap to VM.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

m_doesGC is only needed for ENABLE(DFG_DOES_GC_VALIDATION), and is used for checking if the VM thread's execution is in a state that can allow GC to run.  Hence, it is more related to VM thread execution as opposed to the state of the Heap.  This patch moves m_doesGC from Heap to VM to get it out of the way of upcoming Global GC work.

Also change DeferGC and DeferGCForAWhile to take a VM& instead of a Heap&.  DeferGC needs to access VM& in order to call VM::verifyCanGC().  DeferGCForAWhile does not need VM&, but we're changing it to be consistent with DeferGC.  There should be no perf impact for this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211111/a23cc1b3/attachment-0001.htm>


More information about the webkit-unassigned mailing list