[Webkit-unassigned] [Bug 232951] Prevent fused multiply add during ParseInt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232951

--- Comment #9 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 443839
  --> https://bugs.webkit.org/attachment.cgi?id=443839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443839&action=review

>>> Source/JavaScriptCore/runtime/ParseInt.h:113
>>> +#pragma GCC optimize ("O0")
>> 
>> 1. Why not only disabling fp-contract? We do not need to disable all optimizations. (See comment https://bugs.webkit.org/show_bug.cgi?id=232951#c5)
>> 2. Why not using function attribute?
>> 3. Use it only for GCC. Clang does not need this.
> 
> I just tried adding `__attribute__((optimize("fp-contract=off")))` locally to the function definition and gcc seems to ignore it, i.e., it generates de fma and the test fails.

Did you try `GCC optimize` pragma and "fp-contract=off" combination?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211110/2e6cf961/attachment-0001.htm>