[Webkit-unassigned] [Bug 232922] bad_optional_access in RenderGrid::updateAutoMarginsInRowAxisIfNeeded

Wed Nov 10 14:44:12 PST 2021

https://bugs.webkit.org/show_bug.cgi?id=232922

--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 443774
  --> https://bugs.webkit.org/attachment.cgi?id=443774
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443774&action=review

> Source/WebCore/ChangeLog:8
> +        Test: fast/css-grid-layout/grid-crash-update-auto-margins-row-axis.html

Nit: the test line should be placed after the description paragraph.

> Source/WebCore/ChangeLog:16
> +

Nit extra line here.

> Source/WebCore/rendering/RenderGrid.cpp:1226
> +    std::optional<LayoutUnit> availableWidth = child.overridingContainingBlockContentLogicalWidth();

Although this seems correct I don't get why we have nullopt in the overriding size here. These two methods are called after calling updateGridAreaBreathLogicalSize() which always sets the overrides. That's why we were calling value() directly here without checking the presence of the value. Do you have more info about the exact conditions that trigger the bad access?

> LayoutTests/fast/css-grid-layout/grid-crash-update-auto-margins-row-axis.html:3
> +<head>

Nit, you don't need neither <html> nor <head> nor <body>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211110/993728ac/attachment-0001.htm>