[Webkit-unassigned] [Bug 232837] nullptr deref in CompositeEditCommand::insertNodeAt

Mon Nov 8 15:08:13 PST 2021

https://bugs.webkit.org/show_bug.cgi?id=232837

--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 443600
  --> https://bugs.webkit.org/attachment.cgi?id=443600
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443600&action=review

> LayoutTests/fast/editing/editing-position-crash.html:1
> +<!DOCTYPE html>

The rest of the change seems fine, but this test case looks like it could use some cleanup. A few confusing/odd details:
- The html closing tag on line 2
- The use of try-catch in the event handlers (as well as the names of all the event handler functions)
- The text node after the end of the body element.
- Lack of explicit closing tags on a few of the elements below, such as the svg.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211108/7b6ecb99/attachment.htm>