[Webkit-unassigned] [Bug 232265] Refactoring and PutByVal cleanup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232265

Mikhail R. Gadelha <mikhail at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikhail at igalia.com

--- Comment #6 from Mikhail R. Gadelha <mikhail at igalia.com> ---
Comment on attachment 442524
  --> https://bugs.webkit.org/attachment.cgi?id=442524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442524&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2513
>> +#endif
> 
> Is it worth making this code JSValueRegs based?

OK

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:2547
>> +#endif
> 
> ditto

OK

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:3555
>> +        compilePutByVal(node);
> 
> why? This seems to be just moving code around within the same file. Is the goal just to have compilePutByVal functions on both 32-bit and 64-bit, even though they don't share an implementation?

Shipping a shared implementation was my initial plan but I thought the patch was already too long. I'll update it with the shared implementation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211103/634a1b63/attachment-0001.htm>