[Webkit-unassigned] [Bug 232512] Fix a null ptr deref by checking that newOffset is a valid key before adding to the HashMap.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 2 14:47:29 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |wenson_hsieh at apple.com

--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 443134
  --> https://bugs.webkit.org/attachment.cgi?id=443134

View in context: https://bugs.webkit.org/attachment.cgi?id=443134&action=review

It looks like the newly added test is failing on test runners.

> Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp:291
> +        if (offsets.isValidKey(newOffset)) {

Nit - we generally prefer early returns over multiline if statements like this.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211102/fe3cfc6a/attachment.htm>

More information about the webkit-unassigned mailing list