[Webkit-unassigned] [Bug 229826] [JSC] Implement Temporal.Instant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229826

--- Comment #36 from Philip Chimento <philip.chimento at gmail.com> ---
(In reply to Yusuke Suzuki from comment #34)
> > Source/JavaScriptCore/runtime/TemporalInstant.cpp:233
> > +    int64_t microseconds = JSBigInt::toBigInt64(bigint);
> 
> It is not handling negative Int128 ranges (if JSBigInt's 2 digits are larger
> than INT128_MAX, then if it is signed, it is not within Int128 range).
> Can you fix it and add test for this?

I guess you mean INT64_MAX here?

I've fixed these cases, added tests, and added the assertion.

Additionally I adjusted the test with the BigInt('9'.repeat(2147483648)) case, because I suspect that constructing that string was what was making the jsc-armv7 tests fail. (Anyway, the test was not actually testing what we thought it would, because BigInts that large are not allowed.)

Hopefully ready to land this time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211101/7e166fca/attachment.htm>