[Webkit-unassigned] [Bug 226383] Adopt Reveal for phone numbers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226383

--- Comment #7 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 430063
  --> https://bugs.webkit.org/attachment.cgi?id=430063
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430063&action=review

> Source/WebKit/ChangeLog:3
> +        Adopted reveal for phone numbers

Nit: "Adopt reveal for phone numbers".

> Source/WebKit/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=226383

You can include the radar URL below this line.

> Source/WebKit/ChangeLog:6
> +        Reviewed by Aditya Keerthi and Wenson Hsieh.

This should be left as NOBODY (OOPS!), until you've received an "r+".

> Source/WebKit/Platform/mac/MenuUtilities.mm:121
> +    auto context = adoptNS([PAL::allocRVPresentingContextInstance() initWithPointerLocationInView:NSZeroPoint inView:(NSView *)viewForPresenter highlightDelegate:(id<RVPresenterHighlightDelegate>)delegate]);

This should be `viewForPresenter.get()` and `delegate.get()`, not casted.

> Source/WebKit/Platform/mac/MenuUtilities.mm:122
> +    NSArray *proposedMenuItems = [presenter menuItemsForItem:(RVItem *)item documentContext:nil presentingContext:(RVPresentingContext *)context options:nil];

`.get()` instead of casting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210528/bdd73f83/attachment.htm>