[Webkit-unassigned] [Bug 226383] Adopt Reveal for phone numbers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 28 12:25:46 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=226383

--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 430034
  --> https://bugs.webkit.org/attachment.cgi?id=430034
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430034&action=review

It looks like we'll need to add a declaration for `-initWithURL:rangeInContext:` in PAL's RevealSPI.h as well, to fix the non-internal macOS build.

> Source/WebKit/Platform/mac/MenuUtilities.mm:112
>      if (!DataDetectorsLibrary())

It's probably a good idea to change this to `!PAL::isRevealFrameworkAvailable() || !PAL::isRevealCoreFrameworkAvailable()` instead, since the new code uses Reveal instead of DataDetectors.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210528/93181c0f/attachment.htm>


More information about the webkit-unassigned mailing list