[Webkit-unassigned] [Bug 226383] Adopt Reveal for phone numbers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226383

Aditya Keerthi <akeerthi at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |akeerthi at apple.com

--- Comment #3 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 430034
  --> https://bugs.webkit.org/attachment.cgi?id=430034
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430034&action=review

> Source/WebKit/ChangeLog:8
> +        Covered by existing tests.

I don't think we have tests for this :)

You can explain how you manually tested instead.

> Source/WebKit/Platform/mac/MenuUtilities.mm:109
> +
> +

Remove this whitespace.

> Source/WebKit/Platform/mac/MenuUtilities.mm:119
> +    auto viewForPresenter = [[NSView alloc] init];

These should all use `adoptNS()` to avoid leaks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210528/0153443b/attachment-0001.htm>