[Webkit-unassigned] [Bug 222098] Regression: Raw AudioBufferSourceNode playback causes repeated crackling sound

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222098

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ggaren at apple.com,
                   |                            |mark.lam at apple.com

--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
The javascript wrappers are no longer getting garbage collected in a timely fashion after a while. As a result, our implementation nodes aren't either.

It could be a JSC garbage collection issue or an issue with AudioScheduledSourceNode::virtualHasPendingActivity() as the wrapper stays alive as long as this function returns true.

The implementation of AudioScheduledSourceNode::virtualHasPendingActivity() seems sensible though:
```
bool AudioScheduledSourceNode::virtualHasPendingActivity() const
{
    return m_hasEndedEventListener && m_playbackState != FINISHED_STATE && !isMarkedForDeletion() && !context().isClosed();
}
```

And from my logging, I do see m_playbackState becoming FINISHED_STATE in a timely fashion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210528/41ab4a8e/attachment.htm>