[Webkit-unassigned] [Bug 226174] [css-grid] Add discrete animation support for grid-template-columns|rows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226174

--- Comment #12 from Oriol Brufau <obrufau at igalia.com> ---
Comment on attachment 429861
  --> https://bugs.webkit.org/attachment.cgi?id=429861
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429861&action=review

Looks good, thanks! Just some nits

> Source/WebCore/ChangeLog:10
> +        Reviewed by  Antoine Quint.

Nit: double space in "by  Antoine"

> Source/WebCore/animation/CSSPropertyAnimation.cpp:754
> +    {

Nit: remove the indentation. I think the curly brackets should be aligned with GridTemplateTracksWrapper, not with the commas.

> Source/WebCore/animation/CSSPropertyAnimation.cpp:766
> +    // ...

Nit: remove this comment

> Source/WebCore/animation/CSSPropertyAnimation.cpp:767
> +    {

Nit: ditto (indentation)

> LayoutTests/imported/w3c/ChangeLog:6
> +        Reviewed by  Antoine Quint.

Nit: ditto (spaces)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210527/19db22d8/attachment.htm>