[Webkit-unassigned] [Bug 226296] [WASM-Function-References] Add support for (ref null? $t) type constructor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226296

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com

--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 429803
  --> https://bugs.webkit.org/attachment.cgi?id=429803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429803&action=review

Nice. Quick comment on ChangeLog files.

> Source/JavaScriptCore/ChangeLog:85
> +        JSTests:
> +        * wasm/function-references/ref_types.js: Added.
> +        (module):
> +        (async testRefTypeLocal):
> +        (async testNonNullRefTypeLocal):
> +        (async testRefTypeInSignature):
> +        (async testRefTypeParamCheck):
> +        (async testRefGlobalCheck):
> +        (async testExternFuncrefNonNullCheck):
> +        (async testExternrefCompatibility):
> +        (async testNonNullExternrefIncompatible):
> +        (async testFuncrefCompatibility):
> +        (async testNonNullFuncrefIncompatible):
> +        * wasm/wasm.json:
> +
> +        Source/JavaScriptCore:
> +        * wasm/WasmAirIRGenerator.cpp:
> +        (JSC::Wasm::AirIRGenerator::gTypeIdx):
> +        (JSC::Wasm::AirIRGenerator::tmpForType):
> +        (JSC::Wasm::AirIRGenerator::emitCCall):
> +        (JSC::Wasm::AirIRGenerator::moveOpForValueType):
> +        (JSC::Wasm::AirIRGenerator::AirIRGenerator):
> +        (JSC::Wasm::AirIRGenerator::addLocal):
> +        (JSC::Wasm::AirIRGenerator::addConstant):
> +        (JSC::Wasm::AirIRGenerator::addRefFunc):
> +        * wasm/WasmCallingConvention.h:
> +        (JSC::Wasm::WasmCallingConvention::marshallLocation const):
> +        (JSC::Wasm::JSCallingConvention::marshallLocation const):
> +        * wasm/WasmFormat.h:
> +        (JSC::Wasm::isSubtype):
> +        (JSC::Wasm::isValidHeapTypeKind):
> +        (JSC::Wasm::isDefaultableType):
> +        * wasm/WasmFunctionParser.h:
> +        (JSC::Wasm::FunctionParser<Context>::parse):
> +        (JSC::Wasm::FunctionParser<Context>::parseAnnotatedSelectImmediates):
> +        (JSC::Wasm::FunctionParser<Context>::checkBranchTarget):
> +        (JSC::Wasm::FunctionParser<Context>::parseExpression):
> +        * wasm/WasmGlobal.cpp:
> +        (JSC::Wasm::Global::get const):
> +        (JSC::Wasm::Global::set):
> +        * wasm/WasmLLIntGenerator.cpp:
> +        (JSC::Wasm::LLIntGenerator::callInformationForCaller):
> +        (JSC::Wasm::LLIntGenerator::callInformationForCallee):
> +        (JSC::Wasm::LLIntGenerator::addArguments):
> +        * wasm/WasmParser.h:
> +        (JSC::Wasm::Parser<SuccessType>::parseBlockSignature):
> +        (JSC::Wasm::Parser<SuccessType>::parseValueType):
> +        (JSC::Wasm::Parser<SuccessType>::parseRefType):
> +        * wasm/WasmSectionParser.cpp:
> +        (JSC::Wasm::SectionParser::parseType):
> +        (JSC::Wasm::SectionParser::parseElement):
> +        (JSC::Wasm::SectionParser::parseInitExpr):
> +        (JSC::Wasm::SectionParser::parseElementSegmentVectorOfExpressions):
> +        (JSC::Wasm::SectionParser::parseGlobalType):
> +        * wasm/WasmSignature.cpp:
> +        (JSC::Wasm::computeHash):
> +        * wasm/generateWasmOpsHeader.py:
> +        * wasm/js/WasmToJS.cpp:
> +        (JSC::Wasm::wasmToJS):
> +        * wasm/js/WebAssemblyFunction.cpp:
> +        (JSC::JSC_DEFINE_HOST_FUNCTION):
> +        * wasm/js/WebAssemblyModuleRecord.cpp:
> +        (JSC::WebAssemblyModuleRecord::linkImpl):
> +        * wasm/wasm.json:

Please remove this duplicate entry.
And these entries are including files that are not in Source/JavaScriptCore.

> JSTests/ChangeLog:75
> +        Source/JavaScriptCore:
> +        * wasm/WasmAirIRGenerator.cpp:
> +        (JSC::Wasm::AirIRGenerator::gTypeIdx):
> +        (JSC::Wasm::AirIRGenerator::tmpForType):
> +        (JSC::Wasm::AirIRGenerator::emitCCall):
> +        (JSC::Wasm::AirIRGenerator::moveOpForValueType):
> +        (JSC::Wasm::AirIRGenerator::AirIRGenerator):
> +        (JSC::Wasm::AirIRGenerator::addLocal):
> +        (JSC::Wasm::AirIRGenerator::addConstant):
> +        (JSC::Wasm::AirIRGenerator::addRefFunc):
> +        * wasm/WasmCallingConvention.h:
> +        (JSC::Wasm::WasmCallingConvention::marshallLocation const):
> +        (JSC::Wasm::JSCallingConvention::marshallLocation const):
> +        * wasm/WasmFormat.h:
> +        (JSC::Wasm::isSubtype):
> +        (JSC::Wasm::isValidHeapTypeKind):
> +        (JSC::Wasm::isDefaultableType):
> +        * wasm/WasmFunctionParser.h:
> +        (JSC::Wasm::FunctionParser<Context>::parse):
> +        (JSC::Wasm::FunctionParser<Context>::parseAnnotatedSelectImmediates):
> +        (JSC::Wasm::FunctionParser<Context>::checkBranchTarget):
> +        (JSC::Wasm::FunctionParser<Context>::parseExpression):
> +        * wasm/WasmGlobal.cpp:
> +        (JSC::Wasm::Global::get const):
> +        (JSC::Wasm::Global::set):
> +        * wasm/WasmLLIntGenerator.cpp:
> +        (JSC::Wasm::LLIntGenerator::callInformationForCaller):
> +        (JSC::Wasm::LLIntGenerator::callInformationForCallee):
> +        (JSC::Wasm::LLIntGenerator::addArguments):
> +        * wasm/WasmParser.h:
> +        (JSC::Wasm::Parser<SuccessType>::parseBlockSignature):
> +        (JSC::Wasm::Parser<SuccessType>::parseValueType):
> +        (JSC::Wasm::Parser<SuccessType>::parseRefType):
> +        * wasm/WasmSectionParser.cpp:
> +        (JSC::Wasm::SectionParser::parseType):
> +        (JSC::Wasm::SectionParser::parseElement):
> +        (JSC::Wasm::SectionParser::parseInitExpr):
> +        (JSC::Wasm::SectionParser::parseElementSegmentVectorOfExpressions):
> +        (JSC::Wasm::SectionParser::parseGlobalType):
> +        * wasm/WasmSignature.cpp:
> +        (JSC::Wasm::computeHash):
> +        * wasm/generateWasmOpsHeader.py:
> +        * wasm/js/WasmToJS.cpp:
> +        (JSC::Wasm::wasmToJS):
> +        * wasm/js/WebAssemblyFunction.cpp:
> +        (JSC::JSC_DEFINE_HOST_FUNCTION):
> +        * wasm/js/WebAssemblyModuleRecord.cpp:
> +        (JSC::WebAssemblyModuleRecord::linkImpl):
> +        * wasm/wasm.json:
> +

They are JSC's entries. Please do not include them in JSTests/ChangeLog.
Entries should be auto-generated by webkit-patch upload --update-changelogs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210527/d87d4c5e/attachment-0001.htm>