[Webkit-unassigned] [Bug 212327] [GTK4] Add support for navigation gestures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 27 01:37:48 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=212327

--- Comment #14 from Alexander Mikhaylenko <alexm at gnome.org> ---
(In reply to Michael Catanzaro from comment #12)
> Hm, do you think we should create a bug to change
> webkit_web_view_get_snapshot_finish() to return a GdkTexture rather than a
> cairo_surface_t? It might be nice to remove cairo from WebKit's API?

Agree

> Also I don't like transferring ownership via a raw pointer in C++. That
> should only happen in legacy code or when we call external library
> functions. Instead, here you should return a GRefPtr<GskRenderNode>. Just
> return adoptGRef() here instead of calling adoptGRef(createTextureNode(...))
> elsewhere.

Or I can just get rid of that function. It's just one render node, might as well create it manually without GtkSnapshot like we already do for color nodes.

> Nit: we don't normally leave a blank line before return.
> Nit: !! is often required in C
> Looking at its usage in the cross-platform ViewSnapshot.cpp

Fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210527/5dbb3d8d/attachment-0001.htm>


More information about the webkit-unassigned mailing list