[Webkit-unassigned] [Bug 226275] #ifdef out transformToColorSpace() in ImageBuffer and subclasses to make it clear it is only needed for non-CG ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226275

--- Comment #2 from Sam Weinig <sam at webkit.org> ---
ENABLE_IMAGE_BUFFER_SUPPORTS_COLOR_SPACE is not great, because it will be really confusing to see:

#if !ENABLE(IMAGE_BUFFER_SUPPORTS_COLOR_SPACE)
    maskerData->maskImage->transformToColorSpace(colorSpace);
#endif

Perhaps the real answer is that we need to replace transformToColorSpace() with something that makes it clear it is not really correct. Like a function that just does a getPixelBuffer -> colorSpace transformation > setPixelBuffer(), though that would obviously be less efficient so not a good idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210526/4a71b67a/attachment.htm>