[Webkit-unassigned] [Bug 226184] Remove deprecated API usage in PageClientImplMac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 24 14:17:32 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=226184

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #429561|review?                     |review+
              Flags|                            |

--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 429561
  --> https://bugs.webkit.org/attachment.cgi?id=429561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429561&action=review

r=me, nice!

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:447
> +    NSPoint windowCoord = [[m_view window] convertPointFromScreen:point];

NIT: I think you can `m_view.window` :)

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:455
> +    tempRect.origin = [[m_view window] convertPointToScreen:tempRect.origin];

ditto (:447)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210524/626d3adc/attachment.htm>


More information about the webkit-unassigned mailing list