[Webkit-unassigned] [Bug 226174] [css-grid] Add discrete animation support for grid-template-columns|rows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226174

--- Comment #2 from Oriol Brufau <obrufau at igalia.com> ---
Comment on attachment 429527
  --> https://bugs.webkit.org/attachment.cgi?id=429527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429527&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:700
> +class GridTemplateColumnsWrapper final : public AnimationPropertyWrapperBase {

These 2 classes are almost identical. Maybe you could merge them into e.g. GridTemplateTracksWrapper? And then use something like

  new GridTemplateTracksWrapper(CSSPropertyGridTemplateColumns, &RenderStyle::gridColumns, &RenderStyle::setGridColumns, &RenderStyle::gridAutoRepeatColumns, &RenderStyle::setGridAutoRepeatColumns),
  new GridTemplateTracksWrapper(CSSPropertyGridTemplateRows, &RenderStyle::gridRows, &RenderStyle::setGridRows, &RenderStyle::gridAutoRepeatRows, &RenderStyle::setGridAutoRepeatRows),

> Source/WebCore/animation/CSSPropertyAnimation.cpp:707
> +    {        

Nit: remove trailing spaces

> Source/WebCore/animation/CSSPropertyAnimation.cpp:743
> +    {        

Nit: remove trailing spaces

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210524/02f0d2b1/attachment-0001.htm>