[Webkit-unassigned] [Bug 226108] New: Rename ImageBuffer::transformColorSpace to transformToColorSpace, and it should take a single argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=226108

            Bug ID: 226108
           Summary: Rename ImageBuffer::transformColorSpace to
                    transformToColorSpace, and it should take a single
                    argument
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com
                CC: sabouhallawa at apple.com

(In reply to Said Abou-Hallawa from bug #225907 comment #11)
> Comment on attachment 429266 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429266&action=review
> 
> > Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:103
> > +    m_parameters.colorSpace = destColorSpace;
> > +
> 
> This change suggests that transformColorSpace() should take only
> destColorSpace. I checked the callers of this function and I found they all
> pass the same colorSpace they used to create the ImageBuffer with. So I
> would suggest:
> 1. Change the name of this function to transformToColorSpace
> 2. Make it take only a newColorSpace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210521/d3291318/attachment.htm>