[Webkit-unassigned] [Bug 225941] WKRemoteObjectRegistry _invokeMethod needs to check for nil completionHandlers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225941

--- Comment #4 from Julian Gonzalez <julian_a_gonzalez at apple.com> ---
(In reply to Alex Christensen from comment #3)
> Comment on attachment 428999 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428999&action=review
> 
> > Source/WebKit/ChangeLog:10
> > +        _invokeMethod's argument-checking loop needs to be run
> > +        even if replyInfo is nil, as otherwise we can call perform an invocation
> > +        with a nil completion handler.
> 
> I'm not sure this description is complete.  I think the problem is that we
> call [invocation invoke] on an invocation that says it has a block argument
> by having the description be "@?" but doesn't actually have one.
> 

Yep, the `nil` completion block is really from the perspective of the called function. I'll re-word this.

> The change looks good, though.  I'm not sure a log is necessary but it
> wouldn't hurt.  The other logs are to help with legitimate use, but this
> can't happen with legitimate use.
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:112
> > +TEST(IPCTestingAPI, CanDetectNilReplyBlocks)
> 
> Test needs some work.  It passes for me even without the fix.

Working on this, we turned up some interesting causes in chat.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210519/46a3c733/attachment.htm>