[Webkit-unassigned] [Bug 225907] ASSERTION FAILED: m_imageBufferResult->colorSpace() == m_resultColorSpace in FilterEffect::copyPremultipliedResult

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225907

--- Comment #5 from Sam Weinig <sam at webkit.org> ---
(In reply to Fujii Hironori from comment #3)
> 3. convertImagePixels doesn't support color space conversion yet for
> USE(ACCELERATE) && USE(CG).
>   
> https://github.com/WebKit/WebKit/blob/
> 3de6f842827f19bb0b6de1068d88026e8868cf26/Source/WebCore/platform/graphics/
> PixelBufferConversion.cpp#L254

Is convertImagePixels() actually being used for any color space conversions on non-CoreGraphics ports? My intent was that it wouldn't be, but I could have easily looked over something?

I think it would be great if we could converge on a single color space transformation tactic for both CoreGraphics and non-CoreGraphics platforms. I happen to like the CoreGraphics approach which is that ImageBuffers have a color space that is immutable, and if you want to change the color space, you draw into another ImageBuffer which has the right color space and the conversion is done during the drawing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210518/aaaccfb9/attachment.htm>