[Webkit-unassigned] [Bug 225800] [MSE] MediaSample that need to be removed with SourceBufferPrivate::evictCodedFrames() may not be removed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225800

Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #428607|review?                     |review-
              Flags|                            |

--- Comment #2 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 428607
  --> https://bugs.webkit.org/attachment.cgi?id=428607
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428607&action=review

> Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:703
> -    while (rangeStart > minimumRangeStart) {
> +    while (rangeEnd > minimumRangeStart) {

Comparing `rangeEnd` to `mininimumRangeStart` feels wrong here.  Perhaps we just need to restructure this code to correctly set `minimumRangeStart` to the beginning of the next buffered range, if that time is > `minimumRangeStart`.  Then this while loop can look identical to the while loop above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210517/f29e9fec/attachment.htm>