[Webkit-unassigned] [Bug 225777] New: Misc GCC warning cleanup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225777

            Bug ID: 225777
           Summary: Misc GCC warning cleanup
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: bugs-noreply at webkitgtk.org

Regular boring compiler warning cleanup:

[909/5319] Building CXX object Source/WebDriver/CMakeFiles/WebDriver.dir/glib/WebDriverServiceGLib.cpp.o
../../Source/WebDriver/glib/WebDriverServiceGLib.cpp: In function ‘bool WebDriver::parseVersion(const WTF::String&, uint64_t&, uint64_t&, uint64_t&)’:
../../Source/WebDriver/glib/WebDriverServiceGLib.cpp:38:10: warning: unused variable ‘ok’ [-Wunused-variable]
   38 |     bool ok;
      |          ^~

Can be removed.

[2471/5319] Building CXX object Source/WebCore/CMakeFiles...vedSources/unified-sources/UnifiedSource-68aea4ac-2.cpp.o
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-68aea4ac-2.cpp:7:
../../Source/WebCore/bindings/js/JSAudioNodeCustom.cpp: In function ‘JSC::JSValue WebCore::toJSNewlyCreated(JSC::JSGlobalObject*, WebCore::JSDOMGlobalObject*, WTF::Ref<WebCore::AudioNode>&&)’:
../../Source/WebCore/bindings/js/JSAudioNodeCustom.cpp:134:1: warning: control reaches end of non-void function [-Wreturn-type]
  134 | }
      | ^

Trivial, just needs RELEASE_ASSERT_NOT_REACHED().

[2791/5319] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-8feba646-15.cpp.o
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-8feba646-15.cpp:5:
../../Source/WebCore/svg/SVGToOTFFontConversion.cpp: In constructor ‘WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter(const WebCore::SVGFontElement&)’:
../../Source/WebCore/svg/SVGToOTFFontConversion.cpp:1454:99: warning: comparison is always true due to limited range of data type [-Wtype-limits]
 1454 |             if (auto value = parseIntegerAllowingTrailingJunk<uint16_t>(segment); value && *value >= 0 && *value < 1000) {
      |                                                                                            ~~~~~~~^~~~

This last warning comes from r277245 which changed an int to unsigned int. I squinted at it for a bit and think that looks probably fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210513/d215e086/attachment.htm>