[Webkit-unassigned] [Bug 180633] Wrong position for orthogonal positioned element with writing-mode: vertical-rl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180633

--- Comment #10 from Oriol Brufau <obrufau at igalia.com> ---
Comment on attachment 427985
  --> https://bugs.webkit.org/attachment.cgi?id=427985
Patch

Overall it looks good to me, but I'm not a WebKit reviewer.

View in context: https://bugs.webkit.org/attachment.cgi?id=427985&action=review

> Source/WebCore/rendering/RenderBox.cpp:3788
> +static void computeLogicalLeftPositionedOffset(LayoutUnit& logicalLeftPos, const RenderBox* child, LayoutUnit logicalWidthValue, const RenderBoxModelObject& containerBlock, LayoutUnit containerLogicalWidth, LayoutUnit bordersPlusPadding)

Nit: rather than adding a new parameter, maybe just add bordersPlusPadding into logicalWidthValue in the callers.
RenderBox::logicalWidth() and RenderBox::logicalHeight() seem to include borders and padding, so this logicalWidthValue should too?

> Source/WebCore/rendering/RenderBox.cpp:4123
> +static void computeLogicalTopPositionedOffset(LayoutUnit& logicalTopPos, const RenderBox* child, LayoutUnit logicalHeightValue, const RenderBoxModelObject& containerBlock, LayoutUnit containerLogicalHeight, LayoutUnit bordersPlusPadding)

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210511/a177057e/attachment-0001.htm>