[Webkit-unassigned] [Bug 225609] New: Reader mode is removing some headings when they are links

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225609

            Bug ID: 225609
           Summary: Reader mode is removing some headings when they are
                    links
           Product: WebKit
           Version: Safari 14
          Hardware: All
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: barry at tunetheweb.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

As discussed in this blog post: https://www.leereamsnyder.com/blog/making-headings-with-links-show-up-in-safari-reader
And demonstrated in this demo page: https://www.tunetheweb.com/experiments/heading-links/
Safari Reader Mode (MacOS BigSur 11.3.1 and iOS 14.5.1) has started hiding headers using the following pattern:

<a href="heading3"><h2 id="heading3">Heading 3</h2></a>

This is a popular pattern used by the links of MDN and the Web Almanac, and when I initially implemented this in in the Web Almanac two years ago I tested this and it did show them (I have a screenshot if you link, but only for Apple Watch, which seems to follow the same heuristics as reader mode and is also broken now).

Weirdly, when there is no paragraph above it, it sometimes leaves the heading in place (but removes the link), but mostly it just removes the heading completely.

The reverse works - and even retains the fact it's a link (though only in MacOS and not in Safari Technology Preview):

<h2 id="heading3"><a href="heading3">Heading 3</a></h2>

Adding a pointless span, returns the heading (though not as a link):

<a href="heading3"><h2 id="heading3"><span>Heading 3</span></h2></a>

Removing a heading completely ruins the reading flow of a document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210510/8bab12ba/attachment.htm>