[Webkit-unassigned] [Bug 225446] Don't allow :visited link style in subtrees that use mix-blend-mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225446

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #427886|review?                     |review+
              Flags|                            |

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 427886
  --> https://bugs.webkit.org/attachment.cgi?id=427886
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427886&action=review

> Source/WebCore/rendering/style/RenderStyle.h:827
> +    void setBlendMode(BlendMode mode)
> +    {
> +        SET_VAR(m_rareNonInheritedData, effectiveBlendMode, static_cast<unsigned>(mode));
> +        SET_VAR(m_rareInheritedData, isInSubtreeWithBlendMode, mode != BlendMode::Normal);
> +    }

I find these multi-line function bodies inside class definitions make it hard for me to get an overview of what’s in the class. Would you consider moving the inline function body below the class definition?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210509/f6cbef6c/attachment.htm>