[Webkit-unassigned] [Bug 225510] [SOUP] Use the new libsoup network metrics API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225510

--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 427994
  --> https://bugs.webkit.org/attachment.cgi?id=427994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427994&action=review

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:286
> +            if (!g_cancellable_is_cancelled(protectCancellable.get()) && !m_networkLoadMetrics.fetchStart) {

The fact that the operation can be cancelled before returning to the main loop is strange and confusing, but you do at least have a warning comment up above, so... I guess that's OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210507/836ea519/attachment-0001.htm>