[Webkit-unassigned] [Bug 225401] New: [LibWebRTC][WPE][GTK] do not use system installed vpx headers when building webrtc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225401

            Bug ID: 225401
           Summary: [LibWebRTC][WPE][GTK] do not use system installed vpx
                    headers when building webrtc
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: yurys at chromium.org

After https://commits.webkit.org/r276491 WPE build fails on Ubuntu 18.04 with the following error:


In file included from ../../../Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9.cc:16:0:
../../../Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/codecs/vp9/vp9_impl.h:134:3: error: ‘vpx_svc_frame_drop_t’ does not name a type; did you mean ‘vpx_enc_frame_flags_t’?
   vpx_svc_frame_drop_t svc_drop_frame_;
   ^~~~~~~~~~~~~~~~~~~~
   vpx_enc_frame_flags_t


This is because #include "vpx/vp8cx.h" in vp9_impl.h gets the header from /usr/include/vpx/vp8cx.h (provided by libvpx-dev)
instead of WebKit/Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/libvpx/vpx/vp8cx.h. vp8cx.h on Ubuntu 18.04 [1]
is rather old and doesn't define vpx_svc_frame_drop_t structure so the build fails.



[1] https://packages.ubuntu.com/source/bionic/libvpx

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210505/33ebc77d/attachment.htm>