[Webkit-unassigned] [Bug 225339] [css-flexbox] Wrong height of an empty table inside an orthogonal flex parent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225339

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |svillar at igalia.com

--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 427629
  --> https://bugs.webkit.org/attachment.cgi?id=427629
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427629&action=review

> Source/WebCore/ChangeLog:15
> +        layout problems (the table is actually empty and may be assigned a different height by its parent).

This paragraph should go in between the "Reviewed by" and the "Test:"

> Source/WebCore/rendering/RenderTable.cpp:538
> +                setLogicalHeight(logicalHeight() + computedLogicalHeight);

What about 

setLogicalHeight(hasOverridingLogicalHeight() ? overridingLogicalHeight() : logicalHeight() + computedLogicalHeight);

we don't fear long lines in WebKit :)

> Source/WebCore/rendering/RenderTable.cpp:609
> +

This add a subtle change for the case of having an empty table with no overriding logical height. We used to cache that value anyway but now you are not doing it. Do we have test coverage for that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210505/458bb39e/attachment.htm>