[Webkit-unassigned] [Bug 225310] [Stable][WPE] 2.32 build Error with ENABLE_VIDEO=OFF/ENABLE_VIDEO_TRACK=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225310

--- Comment #4 from Philippe Normand <pnormand at igalia.com> ---
(In reply to Bastian Krause from comment #0)
> I'm building wpewebkit 2.32.0 via meta-webkit at 4cedcb6 (top of main branch)
> with
> 
>   PACKAGECONFIG_remove = "video"
> 
> That means adding
> 
>   -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF
> 
> leads to these build failures:
> 
> In file included from
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGL.h:30,
>                  from
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGLCommon.cpp:30:
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1310:
> 39: error: 'MediaPlayer' has not been declared
>  1310 |     virtual bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject
> texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum
> format, GCGLenum type, bool premultiplyAlpha, bool flipY) = 0;
>       |                                       ^~~~~~~~~~~
> In file included from
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGLCommon.cpp:30:
> [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/
> wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/
> GraphicsContextGLOpenGL.h:469:10: error: 'bool
> WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia(WebCore::MediaPlayer&,
> PlatformGLObject, GCGLenum, GCGLint, GCGLenum, GCGLenum, GCGLenum, bool,
> bool)' marked 'final', but is not virtual
>   469 |     bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject
> texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum
> format, GCGLenum type, bool premultiplyAlpha, bool flipY) final;
>       |          ^~~~~~~~~~~~~~~~~~~~

But bug 225316 doesn't fix any of that ^^^
I'm confused now :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210504/f506c81e/attachment-0001.htm>