[Webkit-unassigned] [Bug 225268] New: start-local-buildbot-server should fail gracefully for Python 2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225268

            Bug ID: 225268
           Summary: start-local-buildbot-server should fail gracefully for
                    Python 2
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aakash_jain at apple.com

start-local-buildbot-server currently fails with a confusing error when run with python2. 

[CISupport]$python start-local-buildbot-server --ews
Setting up virtualenv at /private/var/folders/k1/w4qtfm5j7_v36jwtf1zg50n00000gn/T/tmpuZB6fl ... 
...
Process Process-1:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 267, in _bootstrap
    self.run()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "start-local-buildbot-server", line 291, in _start_server
    if check_tcp_port_open('localhost', self._server_pb_port):
  File "start-local-buildbot-server", line 79, in check_tcp_port_open
    except ConnectionRefusedError:
NameError: global name 'ConnectionRefusedError' is not defined


ConnectionRefusedError is a built-in exception in Python 3, but doesn't work in Python 2. Instead of failing with this exception, we should gracefully exit when the script is invoked with Python 2 and print a proper error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210501/3936b939/attachment.htm>