[Webkit-unassigned] [Bug 224008] New: [webkitscmpy] Improve git-svn-id regex

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=224008

            Bug ID: 224008
           Summary: [webkitscmpy] Improve git-svn-id regex
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jbedard at apple.com

A git-svn-id is only valid if it is at the beginning of a new line, otherwise, the regex may be matching the git-svn-id of a cherry-picked commit contained inside a given commit. Additionally, it turns out that our mock Git code was generating incorrect git-svn-id lines, but we didn't notice because stripping off the first 4 characters results in "svn-id", which seemed correct enough that we enshrined it in our unit tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210331/92e88549/attachment.htm>