[Webkit-unassigned] [Bug 223916] [JSC] Remove warnings about unnecessary operator= for ARMv7Assembler LinkRecord

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223916

--- Comment #5 from Xan Lopez <xan.lopez at gmail.com> ---
(In reply to Darin Adler from comment #4)
> I think we should interpret GCC's warning as "if you had a reason to
> override operator= then you also need to override copy constructor for the
> same reason", which seems correct!

That makes sense to me, I was thrown off by the doc:

       -Wdeprecated-copy (C++ and Objective-C++ only)
           Warn that the implicit declaration of a copy constructor or copy assignment operator is deprecated if the class has a user-provided copy constructor or copy
           assignment operator, in C++11 and up.  This warning is enabled by -Wextra.  With -Wdeprecated-copy-dtor, also deprecate if the class has a user-provided
           destructor.

I can read that as saying we'd still be warned if any, *or both*, are present? I get now it can be read as you suggest (if you define one, you almost surely want to define the other), but the language is a bit confusing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210330/c176c37c/attachment-0001.htm>