[Webkit-unassigned] [Bug 218576] Debug assertion in RenderTreeUpdater::GeneratedContent::updateQuotesUpTo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218576

--- Comment #10 from Rob Buis <rbuis at igalia.com> ---
(In reply to Ryosuke Niwa from comment #9)
> (In reply to Rob Buis from comment #7)
> > I am not sure anymore the fix is correct, will look again soon.
> 
> Any update on this?

Sorry for the delay! I finally found the root cause, when hitting splitDepth >= cMaxSplitDepth in RenderTreeBuilder::Inline::splitInlines, the tree re-ordering will ruin the existing RenderQuote order, making m_previousUpdatedQuote ordered *after* lastQuote.
Possible solutions:
- remove the ASSERT.
- keep patch as-is.
- clear m_previousUpdatedQuote if splitDepth >= cMaxSplitDepth is hit.
- still update the RenderQuote if not found when starting looking from m_previousUpdatedQuote.
I am not very familiar with the splitting, continuations or quote's though, thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210330/f35b946f/attachment.htm>