[Webkit-unassigned] [Bug 223916] [JSC] Remove unnecessary copy constructor for ARMv7Assembler LinkRecord

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223916

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 424622
  --> https://bugs.webkit.org/attachment.cgi?id=424622
Remove user-provided copy-ctor, v1

If you are going to remove this then I think you need to do more:

1) Research why it was added, since you are claiming it’s not needed. Let’s make sure we don’t lose the context of why someone thought they needed it. Verify they were mistaken or that something has changed.

2) Remove the unused CopyTypes type and copyTypes data member and remove the use of the union entirely since this is the only place it was used.

If you want to take the GCC warning literally, you could add a copy constructor that uses copyTypes instead of removing the assignment operator.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210330/5d7e9a04/attachment.htm>