[Webkit-unassigned] [Bug 223204] Refactor Pair.h to CSSValuePair.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223204

--- Comment #10 from Tyler Wilcock <twilco.o at protonmail.com> ---
Thank you both for the review!

> The practical result of this refactoring appears to be to weaken typing
> in many places.
You're right, this patch is not worth the weaker typing it brings.

> I guess that could be avoided by having a common base class for Primitive/Pair/Quad or by starting to use Variant.

> Would it be possible / practical to have a type, like, CSSPrimitiveValuePair.h which *is* a subclass of CSSValue, but only has CSSPrimitiveValues items for the cases where we don't need to store arbitrary CSSValues as the items? Perhaps even as a subclass of CSSValuePair?
Thanks for these suggestions.  I'll see if I can come up with something that addresses the original problems without weakening (ideally strengthening) the types.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210329/45ad3d9e/attachment-0001.htm>