[Webkit-unassigned] [Bug 223204] Refactor Pair.h to CSSValuePair.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223204

--- Comment #6 from Tyler Wilcock <twilco.o at protonmail.com> ---
Here are the results of Tools/Scripts/dump-class-layout on Pair and CSSValuePair.  There might be more to it than this, but they're equal in this regard at least.  If there's more information that would be useful to gather I'd be happy to do that too.

$ Tools/Scripts/dump-class-layout -c Release WebCore Pair
  +0 < 24> WebCore::Pair
  +0 <  4>     WTF::RefCounted<WebCore::Pair, std::__1::default_delete<WebCore::Pair> > WTF::RefCounted<WebCore::Pair, std::__1::default_delete<WebCore::Pair> >
  +0 <  4>         WTF::RefCountedBase WTF::RefCountedBase
  +0 <  4>           unsigned int m_refCount
  +4 <  1>   WebCore::Pair::IdenticalValueEncoding m_encoding
  +5 <  3>   <PADDING: 3 bytes>
  +8 <  8>     WTF::RefPtr<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue>, WTF::DefaultRefDerefTraits<WebCore::CSSPrimitiveValue> > m_first
  +8 <  8>       WTF::RawPtrTraits<WebCore::CSSPrimitiveValue>::StorageType m_ptr
 +16 <  8>     WTF::RefPtr<WebCore::CSSPrimitiveValue, WTF::RawPtrTraits<WebCore::CSSPrimitiveValue>, WTF::DefaultRefDerefTraits<WebCore::CSSPrimitiveValue> > m_second
 +16 <  8>       WTF::RawPtrTraits<WebCore::CSSPrimitiveValue>::StorageType m_ptr
Total byte size: 24
Total pad bytes: 3
Padding percentage: 12.50 %

$ Tools/Scripts/dump-class-layout -c Release WebCore CSSValuePair
  +0 < 24> WebCore::CSSValuePair
  +0 <  8>     WebCore::CSSValue WebCore::CSSValue
  +0 <  4>       unsigned int m_refCount
  +4 < :7>       unsigned int m_primitiveUnitType : 7
  +4 < :1>       unsigned int m_hasCachedCSSText : 1
  +5 < :2>       unsigned int m_valueSeparator : 2
  +5 < :6>       unsigned int m_classType : 6
  +6 <  1>   WebCore::CSSValuePair::IdenticalValueEncoding m_encoding
  +7 <  1>   <PADDING: 1 byte>
  +8 <  8>     WTF::RefPtr<WebCore::CSSValue, WTF::RawPtrTraits<WebCore::CSSValue>, WTF::DefaultRefDerefTraits<WebCore::CSSValue> > m_first
  +8 <  8>       WTF::RawPtrTraits<WebCore::CSSValue>::StorageType m_ptr
 +16 <  8>     WTF::RefPtr<WebCore::CSSValue, WTF::RawPtrTraits<WebCore::CSSValue>, WTF::DefaultRefDerefTraits<WebCore::CSSValue> > m_second
 +16 <  8>       WTF::RawPtrTraits<WebCore::CSSValue>::StorageType m_ptr
Total byte size: 24
Total pad bytes: 1
Padding percentage: 4.17 %

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210326/e4b91cea/attachment-0001.htm>