[Webkit-unassigned] [Bug 223757] New: Embiggen maximum HashTable size when not using ANGLE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223757

            Bug ID: 223757
           Summary: Embiggen maximum HashTable size when not using ANGLE
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: don.olmstead at sony.com

A HashMap of sh::ShaderVariable is over the limit introduced in https://trac.webkit.org/changeset/274603/webkit

In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:30:
In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:30:
In file included from ../../Source/WebCore/platform/graphics\GraphicsContextGL.h:32:
In file included from ../../Source/WebCore/platform/graphics/Image.h:30:
In file included from ../../Source/WebCore/platform/graphics/DecodingOptions.h:28:
In file included from ../../Source/WebCore/platform/graphics\IntSize.h:29:
In file included from WTF/Headers\wtf/JSONValues.h:35:
In file included from WTF/Headers\wtf/HashMap.h:25:
WTF/Headers\wtf/HashTable.h:671:9: error: static_assert failed due to requirement 'sizeof(WTF::String) + sizeof(WTF::KeyValuePair<WTF::String, sh::ShaderVariable>) < 250' "Your HashTable types are too big to efficiently move when rehashing.  Consider using UniqueRef instead"
        static_assert(sizeof(Key) + sizeof(Value) < 250, "Your HashTable types are too big to efficiently move when rehashing.  Consider using UniqueRef instead");
        ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

....
                  ^
../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:301:63: note: in instantiation of member function 'WTF::HashMap<WTF::String, sh::ShaderVariable, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<sh::ShaderVariable> >::find' requested here
        const auto& fragmentSymbol = fragmentEntry.varyingMap.find(symbolName);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210325/5cebfaef/attachment.htm>