[Webkit-unassigned] [Bug 223695] Metal ANGLE crashes LayoutTests/inspector/canvas/updateShader-webgl.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 24 13:12:45 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=223695

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 424141
  --> https://bugs.webkit.org/attachment.cgi?id=424141
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424141&action=review

> Source/ThirdParty/ANGLE/ChangeLog:4
> +Switch to using allocated dictionaries, rather than stack constants.

What is the exact mechanism for this failure? Literals are not stack constants, and should generally work everywhere.

I wonder if this is covering for an over-release somewhere with a leak.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm:251
> -        mDefaultSubstitutionDictionary = @{@"TRANSFORM_FEEDBACK_ENABLED": @"0"};
> +        mDefaultSubstitutionDictionary = [[NSDictionary alloc] initWithDictionary:@{@"TRANSFORM_FEEDBACK_ENABLED": @"0"}];

There is a code path above that also initializes mDefaultSubstitutionDictionary with a literal. Worth updating that for consistency?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210324/22852cb0/attachment-0001.htm>


More information about the webkit-unassigned mailing list