[Webkit-unassigned] [Bug 214141] [WPE] lost touch events, wrong mousedown events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214141

--- Comment #22 from Marco Felsch <m.felsch at pengutronix.de> ---
(In reply to Marco Felsch from comment #20)
> (In reply to Bastian Krause from comment #14)
> > I am also able to reproduce the bug mentioned by Moritz, triggered by
> > https://jsfiddle.net/h013paz9/show with the latest patch.
> > 
> > Another click event related difference (probably unrelated to this bug?),
> > unrelated to the latest patch:
> > 
> > On desktop Chromium and Android Chrome I observe no click events after long
> > presses > ~2s (tap and hold, with [1]), on wpewebkit click events occur no
> > matter how long the tap and hold gesture lasts.
> > 
> > I cannot reproduce this on mobile Safari as tap and hold gestures make the
> > select function pop up, leading to the end of the gesture without click.
> > 
> > [1] window.addEventListener("contextmenu", function(e) { e.preventDefault();
> > });
> 
> After checking the GTK implementation and the common code, I don't see how
> we could fix this in short. The problem is that we need to track the element
> with the touch_down event. Then we need to check if the touch_up event
> correspond to the same element and then issuing a click() event. Question is
> also, do we need to synthesize the click event? According
> https://w3c.github.io/uievents/#click this is not the case.

So.. after checking the GTK Port I assume that it is okay, that presses longer than 500ms should not trigger the click() event. Why 500ms? Because it is default for 'gtk-long-press' [1]. The interesting code can be found here [2]. The .tap() is only fired if not inDrag. Behind the tap() implementation is the synthesized click() event. Since we don't have properties like 'gtk-long-press' I would go with 500ms. Is that okay for everyone?

[1] https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-long-press-time
[2] Source/WebKit/UIProcess/gtk/GestureController.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210324/ea1caa75/attachment.htm>