[Webkit-unassigned] [Bug 223613] JSGlobalObject's m_customGetterFunctionMap and m_customSetterFunctionMap should be sets, not maps, and should use both the identifier and function pointer as the key

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 17:53:25 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=223613

--- Comment #7 from Alexey Shvayka <shvaikalesh at gmail.com> ---
(In reply to Sam Weinig from comment #4)
>    HashSet<Weak<JSCustomGetterFunction>, CustomHashTraits>
> 
> 
> The question is, can I figure out how to make that work (I am not convinced
> I can).

Yeah, we could also use this approach to replace WeakGCMaps that were introduced in r274528; their std::pair<> keys are stored unnecessarily.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210323/c9f84e36/attachment.htm>


More information about the webkit-unassigned mailing list