[Webkit-unassigned] [Bug 223613] JSGlobalObject's m_customGetterFunctionMap and m_customSetterFunctionMap should be sets, not maps, and should use both the identifier and function pointer as the key

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223613

--- Comment #5 from Alexey Shvayka <shvaikalesh at gmail.com> ---
(In reply to Sam Weinig from comment #4)
> I don't think so, but perhaps you are thinking of something I have missed.
> It should still be O(1). It's essentially just going from 

To preserve identity, JSObject::getOwnPropertyDescriptor() tries to lookup already created JSCustomGetterFunction by given GetValueFunc.

I might be totally missing something obvious, but is it possible to do that quickly with HashSet<Weak<JSCustomGetterFunction>, CustomHashTraits>, without iterating all the entries?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210323/ab2c7dc6/attachment-0001.htm>