[Webkit-unassigned] [Bug 223613] JSGlobalObject's m_customGetterFunctionMap and m_customSetterFunctionMap should be sets, not maps, and should use both the identifier and function pointer as the key

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=223613

--- Comment #3 from Alexey Shvayka <shvaikalesh at gmail.com> ---
(In reply to Sam Weinig from comment #2)
> But, if we can use a set instead, we could take advantage of the fact that
> the JSCustomGetterFunction already stores the PropertyName and GetValueFunc.
> And thus, rather than increase size, we could actually make these a bit
> smaller, since the buckets would now just be Weak<JSCustomGetterFunction>.

Oh, thanks, makes total sense.

Wouldn't that slow down the value lookup to O(N)? If so, I guess it's tolerable for Object.getOwnPropertyDescriptor().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210323/3b91f9b7/attachment-0001.htm>