[Webkit-unassigned] [Bug 216145] [css-grid] Incorrectly stretched SVGs without an aspect-ratio

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216145

--- Comment #3 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 423644
  --> https://bugs.webkit.org/attachment.cgi?id=423644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423644&action=review

The patch looks good, but it doesn't fix all the tests that has been identified as failing due to this bug. We should either fix all of them or create a different bug, which this will depend on, and provide this patch as fix for that.

> Source/WebCore/ChangeLog:8
> +        When SVG element has fixed width or height as 0, it should also be reflected as true for has

s/for has/for

> Source/WebCore/ChangeLog:10
> +        RenderReplaced::computeReplacedLogicalHeight. This change is to differentiate the case when

Could you explain a bit more the case we want to differentiate from ?

> Source/WebCore/platform/graphics/FloatSize.h:75
> +    bool hasWidth = false;

Give than we set it to true if the Length value assigned to FloatSize attributes is Fixed or not, wouldn't be better to define these attributes as isFixed ?

> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:83
> +    intrinsicSize.hasWidth = svgSVGElement().intrinsicWidth().isFixed();

The function computeIntrinsicRatioInformation is overridden by RenderImage as well; shouldn't this class set values to the hasWidth and hasHeight as well ? Otherwise, we'll use the default values for these FloatSize's fields in the RenderReplaced logic.

Additionally, are you sure that isFixed is enough ? Wouldn't be better to check use Length::isSpeficied() instead ? (it includes percent or calculated as well).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210318/28d86913/attachment.htm>